qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 2/3] utils: provide size_to_str()


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v8 2/3] utils: provide size_to_str()
Date: Tue, 16 May 2017 18:34:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Peter Xu <address@hidden> writes:

> Moving the algorithm from print_type_size() into size_to_str() so that
> other component can also leverage it. With that, refactor
> print_type_size().
>
> The assert() in that logic is removed though, since even UINT64_MAX
> would not overflow.

I'd keep it.

> Signed-off-by: Peter Xu <address@hidden>

Regardless:
Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]