[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/22] ioapic: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 08/22] ioapic: Remove user_creatable flag |
Date: |
Wed, 17 May 2017 10:39:49 -0300 |
An ioapic device is already created by the q35 initialization
code, and using "-device ioapic" or "-device kvm-ioapic" will
always fail with "Only 1 ioapics allowed". Remove the
user_creatable flag from the ioapic device classes.
Cc: Igor Mammedov <address@hidden>
Cc: Marcel Apfelbaum <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Acked-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/i386/kvm/ioapic.c | 5 -----
hw/intc/ioapic.c | 5 -----
2 files changed, 10 deletions(-)
diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
index 348c405180..98ca480792 100644
--- a/hw/i386/kvm/ioapic.c
+++ b/hw/i386/kvm/ioapic.c
@@ -167,11 +167,6 @@ static void kvm_ioapic_class_init(ObjectClass *klass, void
*data)
k->post_load = kvm_ioapic_put;
dc->reset = kvm_ioapic_reset;
dc->props = kvm_ioapic_properties;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo kvm_ioapic_info = {
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index f9e4f77def..37c4386ae3 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -448,11 +448,6 @@ static void ioapic_class_init(ObjectClass *klass, void
*data)
k->post_load = ioapic_update_kvm_routes;
dc->reset = ioapic_reset_common;
dc->props = ioapic_properties;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo ioapic_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 01/22] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 03/22] xen-backend: Remove FIXME comment about user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 04/22] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 02/22] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 05/22] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 06/22] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 07/22] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 09/22] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 08/22] ioapic: Remove user_creatable flag,
Eduardo Habkost <=
- [Qemu-devel] [PULL 10/22] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 11/22] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 12/22] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 13/22] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 15/22] esp: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 14/22] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 17/22] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 16/22] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 18/22] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/05/17
- [Qemu-devel] [PULL 19/22] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/05/17