[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] altera_timer: fix incorrect mems
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] altera_timer: fix incorrect memset |
|
Date: |
Thu, 18 May 2017 17:00:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 18/05/2017 12:33, Paolo Bonzini wrote:
> Use sizeof instead of ARRAY_SIZE, fixing -Wmemset-elt-size with recent
> GCC versions.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/timer/altera_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/timer/altera_timer.c b/hw/timer/altera_timer.c
> index 6d4862661d..c9a0fc5dca 100644
> --- a/hw/timer/altera_timer.c
> +++ b/hw/timer/altera_timer.c
> @@ -204,7 +204,7 @@ static void altera_timer_reset(DeviceState *dev)
>
> ptimer_stop(t->ptimer);
> ptimer_set_limit(t->ptimer, 0xffffffff, 1);
> - memset(t->regs, 0, ARRAY_SIZE(t->regs));
> + memset(t->regs, 0, sizeof(t->regs));
> }
>
> static Property altera_timer_properties[] = {
>
Reviewed-by: Laurent Vivier <address@hidden>