[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLO
|
From: |
Niels de Vos |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC |
|
Date: |
Thu, 18 May 2017 17:21:02 +0200 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, May 18, 2017 at 09:30:53AM -0500, Eric Blake wrote:
> On 05/18/2017 04:54 AM, Niels de Vos wrote:
> > Add missing support for "preallocation=falloc" to the Gluster block
> > driver. This change bases its logic on that of block/file-posix.c and
> > removed the gluster_supports_zerofill() and qemu_gluster_zerofill()
> > functiond in favour of #ifdef checks in an easy to read
>
> s/functiond/functions/
>
> > switch-statement.
> >
> > Both glfs_zerofill() and glfs_fallocate() have been introduced with
> > GlusterFS 3.5.0 (pkg-config glusterfs-api = 6). A #define for the
> > availability of glfs_fallocate() has been added to ./configure.
> >
> > Reported-by: Satheesaran Sundaramoorthi <address@hidden>
> > URL: https://bugzilla.redhat.com/1450759
> > Signed-off-by: Niels de Vos <address@hidden>
> > ---
> > v2 changes requested by Jeff Cody:
> > - add CONFIG_GLUSTERFS_FALLOCATE
> > - remove unneeded wrapper qemu_gluster_zerofill()
>
> The automated tools prefer that v2 patches are sent as a new top-level
> thread, rather than buried in-reply-to the v1 thread.
Ok, I'm happy to resend it with the typo corrected if that helps.
Niels