|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams |
Date: | Fri, 19 May 2017 12:54:36 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Juan Quintela <address@hidden> writes: > We have change in the previous patch to use migration capabilities for > it. Notice that we continue using the old command line flags from > migrate command from the time being. Remove the set_params method as > now it is empty. > > For savevm, one can't do a: > > savevm -b/-i foo Yes (savem has no such options). > but now one can do: > > migrate_set_capability block on > savevm foo > > And we can't use block migration. We could disable block capability > unconditionally, but it would not be much better. This leaves me confused: what does the example do? Reading ahead... looks like it fails with "Block migration and snapshots are incompatible". What are you trying to say here? > Signed-off-by: Juan Quintela <address@hidden> > Reviewed-by: Eric Blake <address@hidden> Patch looks good to me.
[Prev in Thread] | Current Thread | [Next in Thread] |