[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/20] virtio-scsi: Unset hotplug handler when unreal
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 16/20] virtio-scsi: Unset hotplug handler when unrealize |
Date: |
Fri, 19 May 2017 13:21:08 +0200 |
From: Fam Zheng <address@hidden>
This matches the qbus_set_hotplug_handler in realize, and it releases
the final reference to the embedded VirtIODevice so that it is
properly finalized.
A use-after-free is fixed with this patch, indirectly:
virtio_device_instance_finalize wasn't called at hot-unplug, and the
vdev->listener would be a dangling pointer in the global and the per
address space listener list. See also RHBZ 1449031.
Cc: address@hidden
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/virtio-scsi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 46a3e3f..f46f06d 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -918,6 +918,9 @@ void virtio_scsi_common_unrealize(DeviceState *dev, Error
**errp)
static void virtio_scsi_device_unrealize(DeviceState *dev, Error **errp)
{
+ VirtIOSCSI *s = VIRTIO_SCSI(dev);
+
+ qbus_set_hotplug_handler(BUS(&s->bus), NULL, &error_abort);
virtio_scsi_common_unrealize(dev, errp);
}
--
1.8.3.1
- [Qemu-devel] [PULL 02/20] mc146818rtc: precisely count the clock for periodic timer, (continued)
- [Qemu-devel] [PULL 02/20] mc146818rtc: precisely count the clock for periodic timer, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 05/20] mc146818rtc: embrace all x86 specific code, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 07/20] msix: trace control bit write op, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 08/20] kvm: irqchip: skip update msi when disabled, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 06/20] kvm: irqchip: trace changes on msi add/remove, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 09/20] Check the return value of fcntl in qemu_set_cloexec, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 10/20] nbd: strict nbd_wr_syncv, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 12/20] nbd: add errp parameter to nbd_wr_syncv(), Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 14/20] nbd/client.c: use errp instead of LOG, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 11/20] nbd: read_sync and friends: return 0 on success, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 16/20] virtio-scsi: Unset hotplug handler when unrealize,
Paolo Bonzini <=
- [Qemu-devel] [PULL 13/20] nbd: add errp to read_sync, write_sync and drop_sync, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 15/20] exec: simplify phys_page_find() params, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 17/20] vhost-user-scsi: Introduce vhost-user-scsi host device, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 19/20] target/i386: enable A20 automatically in system management mode, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 20/20] target/i386: use multiple CPU AddressSpaces, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 18/20] vhost-user-scsi: Introduce a vhost-user-scsi sample application, Paolo Bonzini, 2017/05/19
- Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19, no-reply, 2017/05/19
- Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19, Stefan Hajnoczi, 2017/05/19