[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 15/20] exec: simplify phys_page_find() params
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 15/20] exec: simplify phys_page_find() params |
Date: |
Fri, 19 May 2017 13:21:07 +0200 |
From: Peter Xu <address@hidden>
It really only plays with the dispatchers, so the parameter list does
not need that complexity. This helps for readability at least.
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
exec.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/exec.c b/exec.c
index 96e3ac9..29633cd 100644
--- a/exec.c
+++ b/exec.c
@@ -373,10 +373,11 @@ static inline bool section_covers_addr(const
MemoryRegionSection *section,
int128_getlo(section->size), addr);
}
-static MemoryRegionSection *phys_page_find(PhysPageEntry lp, hwaddr addr,
- Node *nodes, MemoryRegionSection
*sections)
+static MemoryRegionSection *phys_page_find(AddressSpaceDispatch *d, hwaddr
addr)
{
- PhysPageEntry *p;
+ PhysPageEntry lp = d->phys_map, *p;
+ Node *nodes = d->map.nodes;
+ MemoryRegionSection *sections = d->map.sections;
hwaddr index = addr >> TARGET_PAGE_BITS;
int i;
@@ -414,8 +415,7 @@ static MemoryRegionSection
*address_space_lookup_region(AddressSpaceDispatch *d,
section_covers_addr(section, addr)) {
update = false;
} else {
- section = phys_page_find(d->phys_map, addr, d->map.nodes,
- d->map.sections);
+ section = phys_page_find(d, addr);
update = true;
}
if (resolve_subpage && section->mr->subpage) {
@@ -1283,8 +1283,7 @@ static void register_subpage(AddressSpaceDispatch *d,
MemoryRegionSection *secti
subpage_t *subpage;
hwaddr base = section->offset_within_address_space
& TARGET_PAGE_MASK;
- MemoryRegionSection *existing = phys_page_find(d->phys_map, base,
- d->map.nodes,
d->map.sections);
+ MemoryRegionSection *existing = phys_page_find(d, base);
MemoryRegionSection subsection = {
.offset_within_address_space = base,
.size = int128_make64(TARGET_PAGE_SIZE),
--
1.8.3.1
- [Qemu-devel] [PULL 07/20] msix: trace control bit write op, (continued)
- [Qemu-devel] [PULL 07/20] msix: trace control bit write op, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 08/20] kvm: irqchip: skip update msi when disabled, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 06/20] kvm: irqchip: trace changes on msi add/remove, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 09/20] Check the return value of fcntl in qemu_set_cloexec, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 10/20] nbd: strict nbd_wr_syncv, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 12/20] nbd: add errp parameter to nbd_wr_syncv(), Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 14/20] nbd/client.c: use errp instead of LOG, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 11/20] nbd: read_sync and friends: return 0 on success, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 16/20] virtio-scsi: Unset hotplug handler when unrealize, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 13/20] nbd: add errp to read_sync, write_sync and drop_sync, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 15/20] exec: simplify phys_page_find() params,
Paolo Bonzini <=
- [Qemu-devel] [PULL 17/20] vhost-user-scsi: Introduce vhost-user-scsi host device, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 19/20] target/i386: enable A20 automatically in system management mode, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 20/20] target/i386: use multiple CPU AddressSpaces, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 18/20] vhost-user-scsi: Introduce a vhost-user-scsi sample application, Paolo Bonzini, 2017/05/19
- Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19, no-reply, 2017/05/19
- Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19, Stefan Hajnoczi, 2017/05/19