Re: [Qemu-devel] [PATCH v0 0/6] move the tcg files into tcg directory.

[Zhong Yang]

O Fri, May 19, 2017 at 05:14:19PM -0500, Eric Blake wrote:
> On 05/19/2017 02:30 AM, Yang Zhong wrote:
> > Move the tcg relative files into tcg directory, which will make
> > the code more clean in qemu.
> 
> Titling a patch series v0 is a bit unusual (typically, the first version
> is untitled, and the second version is titled v2; 'git send-email -v2'
> can help).  But since 0 is less than 1 or 2, I don't think it breaks any
> tools if you use that as your explicit title for a first submission,
> even if you have to respin.
> 
> > 
> > Yang Zhong (6):
> >   move tcg relative files into tcg directory
> >   move tcg relative files into tcg directory
> >   move tcg header file
> >   move tcg relative files into tcg directory
> >   move tcg relative files into tcg directory
> 
> None of your patches match the usual "topic: Short description" of other
> patches.  Furthermore, having identical titles on 4 out of 6 distinct
> patches is a nightmare for downstream backporters (which "move tcg
> relative files into tcg directory" do I have to backport to fix the bug,
> again?).  I highly suggest that every patch you submit have enough
> details in the subject line that the subject is distinct (we don't
> always succeed, but it's usually quite easy to avoid duplicates).
> 
> So, as an example, I might title a patch:
> 
> "tcg: Move tcg-runtime.c to tcg/ subdirectory"
>
Thanks for your comments, and i will send v2 patchset to commnunity accroding 
to your suggestions.
Please also help review my tcg accelator patchset,many thanks! 

> >   change tcg relative file's compile definition
> > 
> >  Makefile.objs                                | 1 +
> >  Makefile.target                              | 8 ++------
> >  tcg/Makefile.objs                            | 2 ++
> >  tcg-runtime.c => tcg/tcg-runtime.c           | 0
> >  tci.c => tcg/tci.c                           | 0
> >  tcg/trace-events                             | 6 ++++++
> >  translate-all.c => tcg/translate-all.c       | 2 +-
> >  translate-all.h => tcg/translate-all.h       | 0
> >  translate-common.c => tcg/translate-common.c | 0
> >  trace-events                                 | 3 ---
> 
> Thankfully, you've got git rename detection turned on, which makes for
> much nicer reviews.
> 
> >  10 files changed, 12 insertions(+), 10 deletions(-)
> >  create mode 100644 tcg/Makefile.objs
> >  rename tcg-runtime.c => tcg/tcg-runtime.c (100%)
> >  rename tci.c => tcg/tci.c (100%)
> >  create mode 100644 tcg/trace-events
> >  rename translate-all.c => tcg/translate-all.c (99%)
> >  rename translate-all.h => tcg/translate-all.h (100%)
> >  rename translate-common.c => tcg/translate-common.c (100%)
> > 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
>