qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of abort


From: Samuel Thibault
Subject: Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing
Date: Tue, 23 May 2017 09:59:27 +0200
User-agent: NeoMutt/20170113 (1.7.2)

Thomas Huth, on mar. 23 mai 2017 09:25:30 +0200, wrote:
> > /tmp/qemu-test/src/slirp/tcp_input.c: In function ‘tcp_input’:
> > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_p’ may be 
> > used uninitialized in this function
> 
> I've never seen these warnings in tcp_input.c before ... and they also
> look like false positives too me ... 

They are.  It's the classical false-positive:

int foo;
if (blah)
        foo = 1;
...
if (blah)
        f(foo);

where gcc doesn't realize it's the same condition between the
initialization and the use.

If that poses problem, we can force a dumb initialization...

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]