[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/31] target/s390x: Use unwind data for helper_
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 13/31] target/s390x: Use unwind data for helper_lam |
Date: |
Tue, 23 May 2017 11:46:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 23.05.2017 05:02, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/s390x/mem_helper.c | 3 ++-
> target/s390x/translate.c | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
> index d1a7bcd..4ecec74 100644
> --- a/target/s390x/mem_helper.c
> +++ b/target/s390x/mem_helper.c
> @@ -450,10 +450,11 @@ void HELPER(ex)(CPUS390XState *env, uint32_t ilen,
> uint64_t v1, uint64_t addr)
> /* load access registers r1 to r3 from memory at a2 */
> void HELPER(lam)(CPUS390XState *env, uint32_t r1, uint64_t a2, uint32_t r3)
> {
> + uintptr_t ra = GETPC();
> int i;
>
> for (i = r1;; i = (i + 1) % 16) {
> - env->aregs[i] = cpu_ldl_data(env, a2);
> + env->aregs[i] = cpu_ldl_data_ra(env, a2, ra);
> a2 += 4;
>
> if (i == r3) {
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index f9d05b6..1fc58a1 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -2626,7 +2626,6 @@ static ExitStatus op_lam(DisasContext *s, DisasOps *o)
> {
> TCGv_i32 r1 = tcg_const_i32(get_field(s->fields, r1));
> TCGv_i32 r3 = tcg_const_i32(get_field(s->fields, r3));
> - potential_page_fault(s);
> gen_helper_lam(cpu_env, r1, o->in2, r3);
> tcg_temp_free_i32(r1);
> tcg_temp_free_i32(r3);
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 10/31] target/s390x: Use unwind data for helper_clst, (continued)
- [Qemu-devel] [PATCH 10/31] target/s390x: Use unwind data for helper_clst, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 07/31] target/s390x: Use unwind data for helper_clc, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 12/31] target/s390x: Use unwind data for helper_mvst, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 13/31] target/s390x: Use unwind data for helper_lam, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 11/31] target/s390x: Use unwind data for helper_mvpg, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 15/31] target/s390x: Use unwind data for helper_mvcl, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 14/31] target/s390x: Use unwind data for helper_stam, Richard Henderson, 2017/05/22