[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/9] scripts/qmp/qom-set: fix the value argument pass
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 1/9] scripts/qmp/qom-set: fix the value argument passed to srv.command() |
Date: |
Tue, 23 May 2017 14:30:30 +0200 |
From: Greg Kurz <address@hidden>
When invoking the script with -s, we end up passing a bogus value
to QEMU:
$ ./scripts/qmp/qom-set -s /var/tmp/qmp-sock-exp /machine.accel kvm
{}
$ ./scripts/qmp/qom-get -s /var/tmp/qmp-sock-exp /machine.accel
/var/tmp/qmp-sock-exp
This happens because sys.argv[2] isn't necessarily the command line
argument that holds the value. It is sys.argv[4] when -s was also
passed.
Actually, the code already has a variable to handle that. This patch
simply uses it.
Signed-off-by: Greg Kurz <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
scripts/qmp/qom-set | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qmp/qom-set b/scripts/qmp/qom-set
index 54ecfec..94e2778 100755
--- a/scripts/qmp/qom-set
+++ b/scripts/qmp/qom-set
@@ -61,4 +61,4 @@ else:
srv = QEMUMonitorProtocol(socket_path)
srv.connect()
-print srv.command('qom-set', path=path, property=prop, value=sys.argv[2])
+print srv.command('qom-set', path=path, property=prop, value=value)
--
2.7.4
- [Qemu-devel] [PULL 0/9] QAPI patches for 2017-05-23, Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 3/9] shutdown: Simplify shutdown_signal, Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 9/9] qapi-schema: Remove obsolete note from ObjectTypeInfo, Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 4/9] shutdown: Prepare for use of an enum in reset/shutdown_request, Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 7/9] shutdown: Expose bool cause in SHUTDOWN and RESET events, Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 1/9] scripts/qmp/qom-set: fix the value argument passed to srv.command(),
Markus Armbruster <=
- [Qemu-devel] [PULL 8/9] block: Use QDict helpers for --force-share, Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 5/9] shutdown: Preserve shutdown cause through replay, Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 2/9] sockets: Plug memory leak in socket_address_flatten(), Markus Armbruster, 2017/05/23
- [Qemu-devel] [PULL 6/9] shutdown: Add source information to SHUTDOWN and RESET, Markus Armbruster, 2017/05/23
- Re: [Qemu-devel] [PULL 0/9] QAPI patches for 2017-05-23, Stefan Hajnoczi, 2017/05/30