[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] qcow2: Remove unused Error in do_perform_co
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/7] qcow2: Remove unused Error in do_perform_cow() |
|
Date: |
Wed, 24 May 2017 11:48:17 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 23 May 2017 10:21:49 PM CEST, Eric Blake wrote:
>> qcow2_encrypt_sectors() does not need an Error parameter, and we're
>> not checking its value anyway, so we can safely remove it.
>
> Misleading. You are NOT removing the Error parameter from
> qcow2_encrypt_sectors(), but rather are explicitly ignoring any errors
> by passing NULL.
Ok, I'll update the comment in the next revision with something like
what you suggest.
Berto
- Re: [Qemu-devel] [PATCH 3/7] qcow2: Make perform_cow() call do_perform_cow() twice, (continued)
[Qemu-devel] [PATCH 5/7] qcow2: Allow reading both COW regions with only one request, Alberto Garcia, 2017/05/23
[Qemu-devel] [PATCH 7/7] qcow2: Merge the writing of the COW regions with the guest data, Alberto Garcia, 2017/05/23
[Qemu-devel] [PATCH 2/7] qcow2: Use unsigned int for both members of Qcow2COWRegion, Alberto Garcia, 2017/05/23
[Qemu-devel] [PATCH 1/7] qcow2: Remove unused Error in do_perform_cow(), Alberto Garcia, 2017/05/23
[Qemu-devel] [PATCH 4/7] qcow2: Split do_perform_cow() into _read(), _encrypt() and _write(), Alberto Garcia, 2017/05/23
[Qemu-devel] [PATCH 6/7] qcow2: Pass a QEMUIOVector to do_perform_cow_{read, write}(), Alberto Garcia, 2017/05/23
Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Eric Blake, 2017/05/23
- Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Alberto Garcia, 2017/05/24
- Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Anton Nefedov, 2017/05/24
- Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Alberto Garcia, 2017/05/24
- Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Anton Nefedov, 2017/05/24
- Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Alberto Garcia, 2017/05/25
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Alberto Garcia, 2017/05/25
Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW, Kevin Wolf, 2017/05/26