Re: [Qemu-devel] [PATCH 00/12] self-announce updates

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 00/12] self-announce updates
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3f42430 tests: Add a test for qemu self announcments
dbfc50a tests/test-hmp: Add announce parameter tests
913d3ab hmp: Add hmp_announce_self
a668d43 hmp: add announce paraters info/set
9e8f35b announce_timer: Add ability to reset an existing
0c23820 migration: Allow for a limited number of announce timers
1c59722 qmp: Expose qemu_announce_self as a qmp command
6662e88 virtio-net: Allow qemu_announce_self to trigger virtio announcements
220cde3 net: Add a network device specific self-announcement ability
10b866e migration: Switch to using announcement timer
b7e78e9 migration: Introduce announcement timer
df9e8b3 migration: Introduce announce parameters

=== OUTPUT BEGIN ===
Checking PATCH 1/12: migration: Introduce announce parameters...
ERROR: braces {} are necessary for all arms of this statement
#133: FILE: migration/savevm.c:174:
+    if (!qemu_validate_announce_parameters(params, errp))
[...]

ERROR: trailing whitespace
#175: FILE: qapi-schema.json:597:
+#           $

total: 2 errors, 0 warnings, 207 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/12: migration: Introduce announcement timer...
Checking PATCH 3/12: migration: Switch to using announcement timer...
Checking PATCH 4/12: net: Add a network device specific self-announcement 
ability...
Checking PATCH 5/12: virtio-net: Allow qemu_announce_self to trigger virtio 
announcements...
ERROR: braces {} are necessary for all arms of this statement
#49: FILE: hw/net/virtio-net.c:139:
+    if (n->announce_timer->round)
[...]

total: 1 errors, 0 warnings, 55 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/12: qmp: Expose qemu_announce_self as a qmp command...
ERROR: braces {} are necessary for all arms of this statement
#29: FILE: migration/savevm.c:277:
+    if (has_params)
[...]

total: 1 errors, 0 warnings, 45 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/12: migration: Allow for a limited number of announce timers...
Checking PATCH 8/12: announce_timer: Add ability to reset an existing...
ERROR: space prohibited before that close parenthesis ')'
#50: FILE: migration/savevm.c:239:
+    if (--timer->round ) {

total: 1 errors, 0 warnings, 81 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/12: hmp: add announce paraters info/set...
Checking PATCH 10/12: hmp: Add hmp_announce_self...
Checking PATCH 11/12: tests/test-hmp: Add announce parameter tests...
Checking PATCH 12/12: tests: Add a test for qemu self announcments...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden