[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 22/33] target/s390x: Use unwind data for helper_t
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v2 22/33] target/s390x: Use unwind data for helper_trt |
Date: |
Wed, 24 May 2017 12:22:35 -0700 |
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Aurelien Jarno <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/s390x/mem_helper.c | 28 ++++++++++++++++------------
target/s390x/translate.c | 1 -
2 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index fd6dbf7..ff12777 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -781,25 +781,29 @@ uint64_t HELPER(tre)(CPUS390XState *env, uint64_t array,
return array + i;
}
-uint32_t HELPER(trt)(CPUS390XState *env, uint32_t len, uint64_t array,
- uint64_t trans)
+static uint32_t do_helper_trt(CPUS390XState *env, uint32_t len, uint64_t array,
+ uint64_t trans, uintptr_t ra)
{
- uint32_t cc = 0;
- int i;
+ uint32_t i;
for (i = 0; i <= len; i++) {
- uint8_t byte = cpu_ldub_data(env, array + i);
- uint8_t sbyte = cpu_ldub_data(env, trans + byte);
+ uint8_t byte = cpu_ldub_data_ra(env, array + i, ra);
+ uint8_t sbyte = cpu_ldub_data_ra(env, trans + byte, ra);
if (sbyte != 0) {
env->regs[1] = array + i;
- env->regs[2] = (env->regs[2] & ~0xff) | sbyte;
- cc = (i == len) ? 2 : 1;
- break;
+ env->regs[2] = deposit64(env->regs[2], 0, 8, sbyte);
+ return (i == len) ? 2 : 1;
}
}
- return cc;
+ return 0;
+}
+
+uint32_t HELPER(trt)(CPUS390XState *env, uint32_t len, uint64_t array,
+ uint64_t trans)
+{
+ return do_helper_trt(env, len, array, trans, GETPC());
}
void HELPER(cdsg)(CPUS390XState *env, uint64_t addr,
@@ -1275,8 +1279,8 @@ uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc,
uint64_t v1,
get_address(env, 0, b2, d2), 0);
return cc;
case 0xd00:
- cc = helper_trt(env, l, get_address(env, 0, b1, d1),
- get_address(env, 0, b2, d2));
+ cc = do_helper_trt(env, l, get_address(env, 0, b1, d1),
+ get_address(env, 0, b2, d2), 0);
break;
default:
goto abort;
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 447ba07..fed9f17 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -4082,7 +4082,6 @@ static ExitStatus op_tre(DisasContext *s, DisasOps *o)
static ExitStatus op_trt(DisasContext *s, DisasOps *o)
{
TCGv_i32 l = tcg_const_i32(get_field(s->fields, l1));
- potential_page_fault(s);
gen_helper_trt(cc_op, cpu_env, l, o->addr1, o->in2);
tcg_temp_free_i32(l);
set_cc_static(s);
--
2.9.4
- [Qemu-devel] [PATCH v2 13/33] target/s390x: Use unwind data for helper_lam, (continued)
- [Qemu-devel] [PATCH v2 13/33] target/s390x: Use unwind data for helper_lam, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 14/33] target/s390x: Use unwind data for helper_stam, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 15/33] target/s390x: Use unwind data for helper_mvcl, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 16/33] target/s390x: Use unwind data for helper_mvcle, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 19/33] target/s390x: Use unwind data for helper_unpk, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 17/33] target/s390x: Use unwind data for helper_clcle, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 18/33] target/s390x: Use unwind data for helper_cksm, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 20/33] target/s390x: Use unwind data for helper_tr, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 21/33] target/s390x: Use unwind data for helper_tre, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 22/33] target/s390x: Use unwind data for helper_trt,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 23/33] target/s390x: Use unwind data for helper_lctlg, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 24/33] target/s390x: Use unwind data for helper_lctl, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 26/33] target/s390x: Use unwind data for helper_testblock, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 27/33] target/s390x: Use unwind data for helper_tprot, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 25/33] target/s390x: Use unwind data for helper_stctl, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 28/33] target/s390x: Use unwind data for helper_lra, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 31/33] target/s390x: Fix EXECUTE with R1==0, Richard Henderson, 2017/05/24
- [Qemu-devel] [PATCH v2 30/33] target/s390x: Fix some helper_ex problems, Richard Henderson, 2017/05/24