Re: [Qemu-devel] [PATCH 2/4] migration: set dirty_pages_rate before autoconverge logic

[Peter Xu]

On Thu, May 25, 2017 at 10:52:32AM +0000, Felipe Franciosi wrote:
> 
> > On 25 May 2017, at 01:40, Peter Xu <address@hidden> wrote:
> > 
> > On Wed, May 24, 2017 at 05:10:01PM +0100, Felipe Franciosi wrote:
> >> Currently, a "period" in the RAM migration logic is at least a second
> >> long and accounts for what happened since the last period (or the
> >> beginning of the migration). The dirty_pages_rate counter is calculated
> >> at the end this logic.
> >> 
> >> If the auto convergence capability is enabled from the start of the
> >> migration, it won't be able to use this counter the first time around.
> >> This calculates dirty_pages_rate as soon as a period is deemed over,
> >> which allows for it to be used immediately.
> >> 
> >> Signed-off-by: Felipe Franciosi <address@hidden>
> > 
> > You fixed the indents as well, but imho it's okay.
> 
> Yeah a couple of lines were off-by-one space. Fixed it given I was touching 
> the code anyway, hope it's ok with everyone else. Would you normally patch 
> that separately or just mention it in the commit message?

For me normally I don't intentionally touch code up only for
indentation to make sure commit log won't be affected for those lines.
However I'm also okay if we fix some of them, either separately or
squashed into patch like this.

IMHO at last it really depends on the maintainers' flavor on this. :-)

Thanks,

-- 
Peter Xu