[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state |
Date: |
Thu, 25 May 2017 12:50:32 +0000 |
On Thu, May 11, 2017 at 6:16 AM Jonathon Jongsma <address@hidden>
wrote:
> Although the Qemu and spice flags currently have the same value, it
> seems more correct to pass the spice flag values to
> spice_server_kbd_leds(), especially considering that this function
> already makes an effort to convert between the QEMU_*_LED and
> SPICE_KEYBOARD_MODIFIER_* values.
>
> Signed-off-by: Jonathon Jongsma <address@hidden>
>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> ui/spice-input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index 8eeebdb..7fd283b 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -87,7 +87,7 @@ static void kbd_leds(void *opaque, int ledstate)
> if (ledstate & QEMU_CAPS_LOCK_LED) {
> kbd->ledstate |= SPICE_KEYBOARD_MODIFIER_FLAGS_CAPS_LOCK;
> }
> - spice_server_kbd_leds(&kbd->sin, ledstate);
> + spice_server_kbd_leds(&kbd->sin, kbd->ledstate);
> }
>
> /* mouse bits */
> --
> 2.9.3
>
>
> --
Marc-André Lureau