Re: [Qemu-devel] [PATCH 3/4] target/s390x: Implement EXECUTE via new TranslationBlock

[Aurelien Jarno]

On 2017-05-24 15:08, Richard Henderson wrote:
> Previously, helper_ex would construct the insn and then implement
> the insn via direct calls other helpers.  This was sufficient to
> boot Linux but that is all.
> 
> It is easy enough to go the whole nine yards by stashing state for
> EXECUTE within the cpu, and then rely on a new TB to be created
> that properly and completely interprets the insn.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/s390x/cpu.h        |   4 +-
>  target/s390x/helper.c     |   5 ++
>  target/s390x/machine.c    |  19 ++++++++
>  target/s390x/mem_helper.c | 118 
> +++++-----------------------------------------
>  target/s390x/translate.c  |  80 ++++++++++++++++++-------------
>  5 files changed, 85 insertions(+), 141 deletions(-)

Reviewed-by: Aurelien Jarno <address@hidden>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net