Re: [Qemu-devel] [PATCH risu] ppc64: Fix patterns for rotate doubleword instructions

[Programmingkid]

On May 25, 2017, at 4:05 PM, address@hidden wrote:

> On Tue, May 23, 2017 at 11:33:03PM -0300, address@hidden wrote:
>> On Tue, May 23, 2017 at 11:47:30AM +0530, Nikunj A Dadhania wrote:
>>> G 3 <address@hidden> writes:
>>> 
>>>> On May 22, 2017, at 4:32 AM, address@hidden wrote:
>>>> 
>>>> Hello I have also done some work risu. My patches add ppc32 support.  
>>>> Well my patches were made to work with Mac OS X but they are required  
>>>> to work with Linux. Do you think you could help port these patches to  
>>>> Linux?
>>> 
>>> Ziviani did the ppc64 work, lets see if he can spare some time.
>>> 
>>> The patches haven't come right on the mailing list, its tedious to pull
>>> them. Please resend them with git send-mail.
>>> 
>> 
>> Hey, sure I can help. I'll take a look on them.
>> 
>>>> 
>>>> ppc.risu:
>>>> https://patchwork.kernel.org/patch/9697489/
> 
> Hi John,
> 
> What do you think about sharing the same ppc64.risu file to ppc and 
> ppc64/ppc64le. Then, instead of:
> 
> <NAME> PPC64LE 01111...
> 
> we'd have:
> 
> <NAME> PPC 01111...
> 
> So, specific instructions would be:
> 
> <NAME> PPC64LE 01111...
> <NAME> PPC64 01111...
> <NAME> PPC32 01111...
> 
> It will allow users to select the arch by using patterns like: ./risugen
> --pattern "PPC64*", or --pattern "PPC32*".
> 
> Finally, we could rename ppc64.risu to powerpc.risu :).
> 
> What do you think?
> 
> Thanks

I think have two separate files is best. Making the .out file becomes so much 
easier. There is no worry for PPC64 instructions being included accidentally in 
a PPC test. Also generating the .out file wouldn't require the --pattern 
option. There is also the possibility of instructions acting in a different 
manner between the two architectures. The ADD instruction may work without 
problems but instructions that do need to know the bit size of the processor  
like CMP will not be easy to implement on both architectures. 

Thank you