[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 19/22] migration/block: reset dirty bitmap before rea
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PULL 19/22] migration/block: reset dirty bitmap before reading |
Date: |
Fri, 26 May 2017 15:52:43 +0800 |
From: Paolo Bonzini <address@hidden>
Any data that is returned by read may be stale already, the bitmap
has to be cleared before issuing the read.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
---
migration/block.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/block.c b/migration/block.c
index 9e9f031..8fe484e 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -536,6 +536,8 @@ static int mig_save_device_dirty(QEMUFile *f,
BlkMigDevState *bmds,
} else {
nr_sectors = BDRV_SECTORS_PER_DIRTY_CHUNK;
}
+ bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
+
blk = g_new(BlkMigBlock, 1);
blk->buf = g_malloc(BLOCK_SIZE);
blk->bmds = bmds;
@@ -568,7 +570,6 @@ static int mig_save_device_dirty(QEMUFile *f,
BlkMigDevState *bmds,
g_free(blk);
}
- bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
sector += nr_sectors;
bmds->cur_dirty = sector;
--
2.9.4
- [Qemu-devel] [PULL 07/22] block: access io_limits_disabled with atomic ops, (continued)
- [Qemu-devel] [PULL 07/22] block: access io_limits_disabled with atomic ops, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 09/22] block: access wakeup with atomic ops, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 10/22] block: access io_plugged with atomic ops, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 11/22] throttle-groups: only start one coroutine from drained_begin, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 12/22] throttle-groups: do not use qemu_co_enter_next, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 13/22] throttle-groups: protect throttled requests with a CoMutex, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 14/22] util: add stats64 module, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 15/22] block: use Stat64 for wr_highest_offset, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 16/22] block: access write_gen with atomics, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 17/22] block: protect tracked_requests and flush_queue with reqs_lock, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 19/22] migration/block: reset dirty bitmap before reading,
Fam Zheng <=
- [Qemu-devel] [PULL 18/22] block: introduce dirty_bitmap_mutex, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 20/22] block: protect modification of dirty bitmaps with a mutex, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 21/22] block: introduce block_account_one_io, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 22/22] block: make accounting thread-safe, Fam Zheng, 2017/05/26
- Re: [Qemu-devel] [PULL 00/22] Docker and block patches, no-reply, 2017/05/26
- Re: [Qemu-devel] [PULL 00/22] Docker and block patches, Stefan Hajnoczi, 2017/05/30