[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/13] be-hci: use backend functions
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 08/13] be-hci: use backend functions |
Date: |
Fri, 26 May 2017 12:20:05 +0000 |
On Tue, May 9, 2017 at 3:42 PM Marc-André Lureau <
address@hidden> wrote:
> Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead.
>
> be->chr_read should exists if qemu_chr_be_can_write() is true.
>
> (use qemu_chr_be_write(), _impl() bypasses replay)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/bt/hci-csr.c | 9 +++------
>
No maintainer for this file. Andrzej, as author of the file, can you
review?
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/hw/bt/hci-csr.c b/hw/bt/hci-csr.c
> index 0f2021086d..d13192b9b5 100644
> --- a/hw/bt/hci-csr.c
> +++ b/hw/bt/hci-csr.c
> @@ -82,17 +82,14 @@ enum {
>
> static inline void csrhci_fifo_wake(struct csrhci_s *s)
> {
> - Chardev *chr = (Chardev *)s;
> - CharBackend *be = chr->be;
> + Chardev *chr = CHARDEV(s);
>
> if (!s->enable || !s->out_len)
> return;
>
> /* XXX: Should wait for s->modem_state & CHR_TIOCM_RTS? */
> - if (be && be->chr_can_read && be->chr_can_read(be->opaque) &&
> - be->chr_read) {
> - be->chr_read(be->opaque,
> - s->outfifo + s->out_start++, 1);
> + if (qemu_chr_be_can_write(chr)) {
> + qemu_chr_be_write(chr, s->outfifo + s->out_start++, 1);
> s->out_len--;
> if (s->out_start >= s->out_size) {
> s->out_start = 0;
> --
> 2.13.0.rc1.16.gd80b50c3f
>
>
> --
Marc-André Lureau
- [Qemu-devel] [PATCH 04/13] char-win: rename hcom->file, (continued)
- [Qemu-devel] [PATCH 04/13] char-win: rename hcom->file, Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 05/13] char-win: close file handle except with console, Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 06/13] chardev: move headers to include/chardev, Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 07/13] chardev: serial & parallel declaration to own headers, Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 08/13] be-hci: use backend functions, Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 09/13] char: generalize qemu_chr_write_all(), Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 10/13] char: move CharBackend handling in char-fe unit, Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 11/13] Remove/replace chardev/char.h inclusion, Marc-André Lureau, 2017/05/09
- [Qemu-devel] [PATCH 12/13] char: rename functions that are not part of fe, Marc-André Lureau, 2017/05/09