Re: [Qemu-devel] [PATCH v2] nbd/client.c: use errp instead of LOG

[Eric Blake]

On 05/26/2017 06:09 AM, Vladimir Sementsov-Ogievskiy wrote:
> Move to modern errp scheme from just LOGging errors.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> 
> Fixes:
> 
> - local_err initialized to NULL
> - 083 iotest ajusted
> 
> \I feel like an idiot...
> 

We all have days like that ;)


> +++ b/tests/qemu-iotests/083.out
> @@ -69,10 +69,12 @@ read failed: Input/output error
>  
>  === Check disconnect 4 reply ===
>  
> +read failed
>  read failed: Input/output error

Having a double error report is awkward; can we figure out where the
duplication is coming from and trim it down to a single report?

But that can be done as a followup.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature