[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/11] fsdev: fix virtfs-proxy-helper cwd
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PULL 05/11] fsdev: fix virtfs-proxy-helper cwd |
Date: |
Mon, 29 May 2017 11:05:34 +0200 |
Since chroot() doesn't change the current directory, it is indeed a good
practice to chdir() to the target directory and then then chroot(), or
to chroot() to the target directory and then chdir("/").
The current code does neither of them actually. Let's go for the latter.
This doesn't fix any security issue since all of this takes place before
the helper begins to process requests.
Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
fsdev/virtfs-proxy-helper.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 54f7ad1c48f0..4c4238f62e53 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -1129,14 +1129,14 @@ int main(int argc, char **argv)
}
}
- if (chdir("/") < 0) {
- do_perror("chdir");
- goto error;
- }
if (chroot(rpath) < 0) {
do_perror("chroot");
goto error;
}
+ if (chdir("/") < 0) {
+ do_perror("chdir");
+ goto error;
+ }
get_version = false;
#ifdef FS_IOC_GETVERSION
--
2.7.4
- [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 01/11] virtio-9p/xen-9p: move 9p specific bits to core 9p code, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 03/11] 9pfs: drop pdu_push_and_notify(), Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 02/11] fsdev: don't allow unknown format in marshal/unmarshal, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 05/11] fsdev: fix virtfs-proxy-helper cwd,
Greg Kurz <=
- [Qemu-devel] [PULL 06/11] 9pfs: assume utimensat() and futimens() are present, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 09/11] 9pfs: local: resolve special directories in paths, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 04/11] 9pfs: local: fix unlink of alien files in mapped-file mode, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 07/11] util: drop old utimensat() compat code, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 08/11] 9pfs: check return value of v9fs_co_name_to_path(), Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 10/11] 9pfs: local: simplify file opening, Greg Kurz, 2017/05/29
- [Qemu-devel] [PULL 11/11] 9pfs: local: metadata file for the VirtFS root, Greg Kurz, 2017/05/29
- Re: [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525, no-reply, 2017/05/29
- Re: [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525, Stefan Hajnoczi, 2017/05/30