Re: [Qemu-devel] [PATCH v2 14/29] target/s390x: improve 24-bit and 31-bit addresses read

[Thomas Huth]

On 29.05.2017 21:24, Aurelien Jarno wrote:
> Improve fix_address to also handle the 24-bit mode. Rename fix_address
> to wrap_address to better explain what is changed.
> 
> Replace the calls to get_address with x2 = 0 and b2 = 0 by
> call to wrap_address, leading to the removal of this function. Rename
> get_address_31fix into get_address.
> 
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  target/s390x/mem_helper.c | 71 
> +++++++++++++++++++++--------------------------
>  1 file changed, 31 insertions(+), 40 deletions(-)

Looks fine (but the EXECUTE patches from Richard have to be included
first, of course)...

Reviewed-by: Thomas Huth <address@hidden>