[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] migration: Remove section_id parameter f
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] migration: Remove section_id parameter from vmstate_load |
Date: |
Tue, 30 May 2017 11:36:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 30/05/2017 10:37, Juan Quintela wrote:
> Everything else assumes that we always load a device from its own
> savevm handler.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
> ---
> migration/savevm.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 14af5ad..e5dd7ef 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -723,13 +723,13 @@ void vmstate_unregister(DeviceState *dev, const
> VMStateDescription *vmsd,
> }
> }
>
> -static int vmstate_load(QEMUFile *f, SaveStateEntry *se, int version_id)
> +static int vmstate_load(QEMUFile *f, SaveStateEntry *se)
> {
> trace_vmstate_load(se->idstr, se->vmsd ? se->vmsd->name : "(old)");
> if (!se->vmsd) { /* Old style */
> - return se->ops->load_state(f, se->opaque, version_id);
> + return se->ops->load_state(f, se->opaque, se->load_version_id);
> }
> - return vmstate_load_state(f, se->vmsd, se->opaque, version_id);
> + return vmstate_load_state(f, se->vmsd, se->opaque, se->load_version_id);
> }
>
> static void vmstate_save_old_style(QEMUFile *f, SaveStateEntry *se, QJSON
> *vmdesc)
> @@ -1858,7 +1858,7 @@ qemu_loadvm_section_start_full(QEMUFile *f,
> MigrationIncomingState *mis)
> return -EINVAL;
> }
>
> - ret = vmstate_load(f, se, se->load_version_id);
> + ret = vmstate_load(f, se);
> if (ret < 0) {
> error_report("error while loading state for instance 0x%x of"
> " device '%s'", instance_id, idstr);
> @@ -1891,7 +1891,7 @@ qemu_loadvm_section_part_end(QEMUFile *f,
> MigrationIncomingState *mis)
> return -EINVAL;
> }
>
> - ret = vmstate_load(f, se, se->load_version_id);
> + ret = vmstate_load(f, se);
> if (ret < 0) {
> error_report("error while loading state section id %d(%s)",
> section_id, se->idstr);
>