[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when even
From: |
Kamil Rytarowski |
Subject: |
Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available |
Date: |
Tue, 30 May 2017 15:11:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; NetBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 30.05.2017 14:53, Eric Blake wrote:
> On 05/30/2017 01:20 AM, Kamil Rytarowski wrote:
>> Currently ivshmem requires eventfd() which is Linux specific.
>> Do not and build it unconditionally on every Linux/BSD/Solaris.
>>
>> This patch indirectly fixes build failure on NetBSD, where these tools
>> additionally require -lrt for shm_open(3). In future there should be
>> added support for NetBSD and the linking addressed appropriately.
>
> Is this a v2 patch? If so, it's best to repost it as a new top-level
> thread rather than buried in reply to your v1 patch. Also, be sure to
> include v2 in the subject line ('git send-email -v2' works wonders for
> that).
>
I reworked it, fixed title and it's more like v3.
>>
>> Signed-off-by: Kamil Rytarowski <address@hidden>
>> Reviewed-by: Markus Armbruster <address@hidden>
>> ---
>
> It also helps in a v2 submission to list here, after the --- separator,
> how it differs from v1.
>
> More submission hints at http://wiki.qemu.org/Contribute/SubmitAPatch
>
Do I still need to resend it?
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking, (continued)
- Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking, Kamil Rytarowski, 2017/05/22
- Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking, Markus Armbruster, 2017/05/23
- Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking, Kamil Rytarowski, 2017/05/23
- Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking, Markus Armbruster, 2017/05/23
- Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking, Kamil Rytarowski, 2017/05/23
[Qemu-devel] [PATCH] ivshmem-server: ivshmem-clean: Install only when eventfd() is available, Kamil Rytarowski, 2017/05/26
- Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-clean: Install only when eventfd() is available, Marc-André Lureau, 2017/05/26
- [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available, Kamil Rytarowski, 2017/05/30
- Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available, Eric Blake, 2017/05/30
- Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available,
Kamil Rytarowski <=
- Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available, Eric Blake, 2017/05/30
- Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available, Markus Armbruster, 2017/05/31
- Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available, Kamil Rytarowski, 2017/05/31
- Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available, Markus Armbruster, 2017/05/31