Re: [Qemu-devel] [PULL 21/21] vhost-scsi: create a vhost-scsi-common abstraction

[Paolo Bonzini]

On 30/05/2017 16:06, Felipe Franciosi wrote:
>> This breaks the mingw build:
>>
>>  hw/scsi/vhost-scsi-common.c:19:25: fatal error: linux/vhost.h: No such file 
>> or directory
>>   #include <linux/vhost.h>
>>                         ^
>>  compilation terminated.
> Thanks for the report.
> 
> Paolo: I know you wanted this enabled by default whenever virtio was built, 
> but maybe we should stick to a configure switch live vhost-net, vhost-scsi 
> and vhost-vsock?
> 
> Let me know what you think and I'll send an extra patch for it straight away.

This was my mistake.  Your patch broke s390, and when I fixed it I
copied the wrong setting:

default-configs/pci.mak:CONFIG_VHOST_USER_SCSI=$(CONFIG_POSIX)
default-configs/s390x-softmmu.mak:CONFIG_VHOST_USER_SCSI=y

Unfortunately, the mingw docker test doesn't build all targets, so I
missed it.

I would like vhost-user to be available on non-Linux POSIX, but this is
not immediately possible because vhost-backend.c includes the kernel
backend.  So we'll have to change CONFIG_POSIX to CONFIG_LINUX too.

Paolo