Re: [Qemu-devel] [PATCH v2] migration: Allow unregister of save_live handlers

[Dr. David Alan Gilbert]

* Juan Quintela (address@hidden) wrote:
> Peter Xu <address@hidden> wrote:
> > On Wed, May 24, 2017 at 01:21:52PM +0200, Juan Quintela wrote:
> >> Migration non save_live handlers have an ops member that is
> >> dinamically allocated by migration code.  Save_live handlers have it
> >> passed as argument and are responsability of the caller.  Add a new
> >> member is_allocated that remembers if ops has to be freed.  This
> >> allows unregister_savevm() to work with save_live handlers.
> >> 
> >> Signed-off-by: Juan Quintela <address@hidden>
> >
> > I thought Laurent will prepare one patch that will directly remove
> > existing register_savevm() callers, no?
> 
> s390, vmxnet3 and slirp are using it.  I am not sure that we will get
> that ones "changed" so easily.

I think Halil is working on s390,  slirp has a tricky loop I need to
look at again.  And vmxnet3 is...odd.

Dave

> Later, Juan.
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK