Re: [Qemu-devel] [PATCH risu v2] ppc64: Fix patterns for rotate doubleword instructions

[Peter Maydell]

On 30 May 2017 at 16:26, Nikunj A Dadhania <address@hidden> wrote:
> Sandipan Das <address@hidden> writes:
>
>> The patterns for the following instructions are fixed:
>>  * Rotate Left Doubleword then Clear Right (rldcr[.])
>>  * Rotate Left Doubleword Immediate then Clear Right (rldicr[.])
>>  * Rotate Left Doubleword Immediate then Mask Insert (rldimi[.])
>>
>> The first instruction has a typo. For the other two instructions,
>> the extended opcodes are incorrect and the shift field 'sha' is
>> absent. Also, the shift field 'sh' should be used in place of the
>> register field 'rb'.
>>
>> Signed-off-by: Sandipan Das <address@hidden>
>
> Reviewed-by: Nikunj A Dadhania <address@hidden>

Thanks; applied to risu master.

-- PMM