Re: [Qemu-devel] [PATCH 4/4] migration: use dirty_rate_high_cnt more aggressively

[Juan Quintela]

Felipe Franciosi <address@hidden> wrote:
> The commit message from 070afca25 suggests that dirty_rate_high_cnt
> should be used more aggressively to start throttling after two
> iterations instead of four. The code, however, only changes the auto
> convergence behaviour to throttle after three iterations. This makes the
> behaviour more aggressive by kicking off throttling after two iterations
> as originally intended.
>
> Signed-off-by: Felipe Franciosi <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

First, Felipe is doing performance testing with the changes.
Second, if you want autoconverge slower, you can use smaller increments.
So, I think that this is ok.

It is more, if you want you can send numbers of your workloads with
current parameter and removing it altogether to convince me that it is a
good idea just to drop it.

Thanks, Juan.