[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/5] target/sh4: fix reset when using a kernel an
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PULL 2/5] target/sh4: fix reset when using a kernel and an initrd |
Date: |
Tue, 30 May 2017 18:21:40 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-05-30 10:02, Eric Blake wrote:
> On 05/30/2017 05:17 AM, Stefan Hajnoczi wrote:
> > On Mon, May 29, 2017 at 09:30:13PM +0200, Aurelien Jarno wrote:
> >> When a masked exception happens, the SH4 CPU generates a non-masked
> >> reset exception, which then jumps to the reset vector at address
> >> 0xA0000000. While this is emulated correctly in QEMU, this does not
> >> work when using a kernel and initrd as this address then contain an
> >> illegal instruction (and there is no guarantee the kernel and initrd
> >> haven't been overwritten).
> >>
>
> >> + qemu_system_reset_request();
> >> + return;
> >
> > The qemu_system_reset_request() prototype is changing. There is a
> > conflict with another merged pull request. Please rebase onto
> > https://github.com/stefanha/qemu.git staging.
> >
> > target/sh4/helper.c:102:39: error: too few arguments to function call,
> > single argument 'reason' was not specified
> > qemu_system_reset_request();
> > ~~~~~~~~~~~~~~~~~~~~~~~~~ ^
>
> You'll probably want SHUTDOWN_CAUSE_GUEST_RESET as the reason, based on
> the changes made to other target/ files.
Indeed I confirm. This is the same as the triple fault on x86, which
uses SHUTDOWN_CAUSE_GUEST_RESET.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
signature.asc
Description: PGP signature