[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] migration: Use savevm_handlers instead o
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] migration: Use savevm_handlers instead of loadvm copy |
Date: |
Tue, 30 May 2017 20:35:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> There is no reason for having the loadvm_handlers at all. There is
>> only one use, and we can use the savevm handlers.
>>
>> We will remove the loadvm handlers on a following patch.
>
> <snip>
>
>> trace_qemu_loadvm_state_section_partend(section_id);
>> - QLIST_FOREACH(le, &mis->loadvm_handlers, entry) {
>> - if (le->section_id == section_id) {
>> + QTAILQ_FOREACH(se, &savevm_state.handlers, entry) {
>> + if (se->section_id == section_id) {
>
> Isn't this the problem? What guarantees that the se->section_id
> is the same as the source's section_id - I don't think anything.
> It's just dynamically allocated in register_savevm_live so the
> initialisation order on source/dest could be different and you'd
> get different ID. You can't update se->section_id
> unless you guaranteed to updated all of them.
Ok. It worked for me because I was using the same command line in both
sides.
Changed to add load_section_id and adjust all around.
Thanks, Juan.