qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 17/29] target/s390x: fix COMPARE LOGICAL LONG


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 17/29] target/s390x: fix COMPARE LOGICAL LONG EXTENDED
Date: Tue, 30 May 2017 13:11:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 05/29/2017 12:24 PM, Aurelien Jarno wrote:
There are multiple issues with the COMPARE LOGICAL LONG EXTENDED
instruction:
- The test between the two operands is inverted, leading to an inversion
   of the cc values 1 and 2.
- The address and length of an operand continue to be decreased after
   reaching the end of this operand. These values are then wrong write
   back to the registers.
- We should limit the amount of bytes to process, so that interrupts can
   be served correctly.

At the same time rename dest into src1 and src into src3 to match the
operand names and make the code less confusing.

Signed-off-by: Aurelien Jarno<address@hidden>
---
  target/s390x/mem_helper.c | 54 ++++++++++++++++++++++++++++++++---------------
  target/s390x/translate.c  | 20 +++++++++++++-----
  2 files changed, 52 insertions(+), 22 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]