[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/16] block/qcow2: Lock s->lock in prealloca
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/16] block/qcow2: Lock s->lock in preallocate() |
Date: |
Tue, 30 May 2017 16:28:45 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/26/2017 11:55 AM, Max Reitz wrote:
> preallocate() is and will be called only from places that do not lock
Maybe: "that do not otherwise need to lock"
> s->lock: Currently that is qcow2_create2(), as of a future patch it will
> be called from qcow2_truncate(), too.
>
> It therefore makes sense to move locking that mutex into preallocate()
> itself.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 04/16] qemu-img: Expose PreallocMode for resizing, (continued)
- [Qemu-devel] [PATCH v3 05/16] block/file-posix: Small fixes in raw_create(), Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 06/16] block/file-posix: Extract raw_regular_truncate(), Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 07/16] block/file-posix: Generalize raw_regular_truncate, Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 08/16] block/file-posix: Preallocation for truncate, Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 09/16] block/qcow2: Generalize preallocate(), Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 10/16] block/qcow2: Lock s->lock in preallocate(), Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 11/16] block/qcow2: Metadata preallocation for truncate, Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 13/16] block/qcow2: Rename "fail_block" to just "fail", Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 12/16] block/qcow2: Add qcow2_refcount_area(), Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 14/16] block/qcow2: falloc/full preallocating growth, Max Reitz, 2017/05/26
- [Qemu-devel] [PATCH v3 15/16] iotests: Add preallocated resize test for raw, Max Reitz, 2017/05/26