Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

[Peter Xu]

On Wed, May 31, 2017 at 04:28:47AM -0400, Paolo Bonzini wrote:
> 
> > Ok before I move on let's see whether this is what we want...
> > 
> > - firstly, find all machine types:
> > 
> >   pxdev:qemu [edu-fix]# grep -R ".parent = TYPE_MACHINE" * | wc
> >      49     196    2269
> > 
> >   so now we have 49 kinds of machines.
> > 
> > - rename msi_nonbroken into msi_broken, then:
> > 
> >   - x86/arm/spapr/s390 machines are the only ones that don't need to
> >     set msi_broken since they support MSI and have msi_nonbroken set,
> >     either in board init function or in irq chip init function
> > 
> >   - for all the rest of the machines, I should add "msi_broken" in its
> >     machine init() function.
> > 
> > Is this really what we want?
> 
> No, for now I'd rather just go and remove msi_nonbroken.  When someone
> reports a bug, we can add back "msi_broken".

Yeah I would prefer that as well... (considering that real heavy users
should mostly be x86/arm/spapr/s390, and they are not using master
branch I believe)

I'll prepare it later. Thanks.

-- 
Peter Xu