qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/17] acpi: fix s3/s4 disabled type


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH 14/17] acpi: fix s3/s4 disabled type
Date: Wed, 31 May 2017 11:10:45 +0000

On Thu, May 18, 2017 at 4:58 PM Markus Armbruster <address@hidden> wrote:

> Marc-André Lureau <address@hidden> writes:
>
> > Use a more specific bool type.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
>
> Why doesn't this run afoul backward compatibility?  To answer the
> question, we need to enumerate affected external interfaces.
>
>
Right, this will break if we have users such as:

 -global PIIX4_PM.disable_s3=2

With this change, it will now error with:

qemu-system-x86_64: can't apply global PIIX4_PM.disable_s3=2: Invalid
parameter type for 'disable_s3', expected: boolean

Acceptable? otherwise, I drop the patch

thanks
-- 
Marc-André Lureau


reply via email to

[Prev in Thread] Current Thread [Next in Thread]