[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/5] block: Simplify use of BDRV_BLOCK_RAW
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 4/5] block: Simplify use of BDRV_BLOCK_RAW |
|
Date: |
Wed, 31 May 2017 16:56:20 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 2017-05-24 22:28, Eric Blake wrote:
> The lone caller that cares about a return of BDRV_BLOCK_RAW
> (namely, io.c:bdrv_co_get_block_status) completely replaces the
> return value, so there is no point in passing BDRV_BLOCK_DATA.
>
> Signed-off-by: Eric Blake <address@hidden>
Technically true, but conflicts with the documentation in block.h.
If you really want this changed, you should document in block.h what
exactly it is that BDRV_BLOCK_RAW does.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/5] more blkdebug tweaks, Eric Blake, 2017/05/24
- [Qemu-devel] [PATCH v2 1/5] qemu-io: Don't die on second open, Eric Blake, 2017/05/24
- [Qemu-devel] [PATCH v2 2/5] block: Guarantee that *file is set on bdrv_get_block_status(), Eric Blake, 2017/05/24
- [Qemu-devel] [PATCH v2 4/5] block: Simplify use of BDRV_BLOCK_RAW, Eric Blake, 2017/05/24
- [Qemu-devel] [PATCH v2 3/5] block: Allow NULL file for bdrv_get_block_status(), Eric Blake, 2017/05/24
- [Qemu-devel] [PATCH v2 5/5] blkdebug: Support .bdrv_co_get_block_status, Eric Blake, 2017/05/24
- Re: [Qemu-devel] [PATCH v2 0/5] more blkdebug tweaks, Fam Zheng, 2017/05/25