Re: [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
44ac08a qobject: move dump_qobject() from block/ to qobject/
4f36884 RFC: qdict: add uint
ef45589 tests/qdict: check more get_try_int() cases
a9c6698 console: use get_uint() for "head" property
d4c67e9 i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties
10de204 numa: use get_uint() for "size" property
7f367eb pnv-core: use get_uint() for "core-pir" property
6279c33 pvpanic: use get_uint() for "ioport" property
6f0b197 auxbus: use get_uint() for "addr" property
3268fdb arm: use get_uint() for "mp-affinity" property
508afeb xen: use get_uint() for "max-ram-below-4g" property
b3a2677 pc: use get_uint() for "hpet-intcap" property
53fff2c pc: use get_uint() for "apic-id" property
86f858d pc: use get_uint() for "iobase" property
7281251 acpi: use get_uint() for "pci-hole*" properties
cdae6bd acpi: use get_uint() for various acpi properties
2c1168c acpi: use get_uint() for "acpi-pcihp-io*" properties
db85018 platform-bus: use get_uint() for "addr" property
83701a9 bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"
3636325 aspeed: use {set, get}_uint() for "ram-size" property
d45270e pcihp: use get_uint() for "bsel" property
a9e4942 pc-dimm: make "size" property uint64
72501db pc-dimm: use get_uint() for dimm properties
7bcc518 isa: use get_uint() for "io-base"
617b690 qdev: use appropriate getter/setters type
67ef86a apic-common: make "id" property a uint32
46b7af7 qdev: add unsigned properties
f5b425c qdev: make default property int
6ef348c object: use more specific property type names
f505764 q35: fix get_mmcfg_size to use uint64 visitor
cae2768 object: add uint property setter/getter
6981ce5 qapi: update the qobject visitor to use QNUM_U64
ee2fc88 json: learn to parse uint64 numbers
08280db qnum: add uint type
9d558cd tests: remove /qnum/destroy test
cbdb7b5 qapi: Remove visit_start_alternate() parameter promote_int
eaa6ee5 qapi: merge QInt and QFloat in QNum
8f5c108 tests: add more int/number ranges checks
29d8de7 tests: remove alt num-int cases
b2ad700 object: fix potential leak in getters
94718f3 qdev: remove PropertyInfo.qtype field
edf34ae qapi: Reject alternates that can't work with keyval_parse()
bc54967 tests/qapi-schema: Avoid 'str' in alternate test cases
1ac82cc qapi: Document visit_type_any() issues with keyval input
b117faf qobject-input-visitor: Reject non-finite numbers with keyval

=== OUTPUT BEGIN ===
Checking PATCH 1/45: qobject-input-visitor: Reject non-finite numbers with 
keyval...
Checking PATCH 2/45: qapi: Document visit_type_any() issues with keyval input...
Checking PATCH 3/45: tests/qapi-schema: Avoid 'str' in alternate test cases...
Checking PATCH 4/45: qapi: Reject alternates that can't work with 
keyval_parse()...
Checking PATCH 5/45: qdev: remove PropertyInfo.qtype field...
Checking PATCH 6/45: object: fix potential leak in getters...
Checking PATCH 7/45: tests: remove alt num-int cases...
Checking PATCH 8/45: tests: add more int/number ranges checks...
Checking PATCH 9/45: qapi: merge QInt and QFloat in QNum...
ERROR: do not use C99 // comments
#2002: FILE: tests/check-qnum.c:35:
+    // destroy doesn't exit yet

ERROR: do not use C99 // comments
#2017: FILE: tests/check-qnum.c:50:
+    // destroy doesn't exit yet

total: 2 errors, 0 warnings, 1918 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/45: qapi: Remove visit_start_alternate() parameter 
promote_int...
Checking PATCH 11/45: tests: remove /qnum/destroy test...
Checking PATCH 12/45: qnum: add uint type...
Checking PATCH 13/45: json: learn to parse uint64 numbers...
Checking PATCH 14/45: qapi: update the qobject visitor to use QNUM_U64...
Checking PATCH 15/45: object: add uint property setter/getter...
Checking PATCH 16/45: q35: fix get_mmcfg_size to use uint64 visitor...
Checking PATCH 17/45: object: use more specific property type names...
Checking PATCH 18/45: qdev: make default property int...
Checking PATCH 19/45: qdev: add unsigned properties...
Checking PATCH 20/45: apic-common: make "id" property a uint32...
Checking PATCH 21/45: qdev: use appropriate getter/setters type...
Checking PATCH 22/45: isa: use get_uint() for "io-base"...
Checking PATCH 23/45: pc-dimm: use get_uint() for dimm properties...
Checking PATCH 24/45: pc-dimm: make "size" property uint64...
Checking PATCH 25/45: pcihp: use get_uint() for "bsel" property...
Checking PATCH 26/45: aspeed: use {set, get}_uint() for "ram-size" property...
Checking PATCH 27/45: bcm2835_fb: use {get, set}_uint() for "vcram-size" and 
"vcram-base"...
Checking PATCH 28/45: platform-bus: use get_uint() for "addr" property...
Checking PATCH 29/45: acpi: use get_uint() for "acpi-pcihp-io*" properties...
Checking PATCH 30/45: acpi: use get_uint() for various acpi properties...
Checking PATCH 31/45: acpi: use get_uint() for "pci-hole*" properties...
Checking PATCH 32/45: pc: use get_uint() for "iobase" property...
Checking PATCH 33/45: pc: use get_uint() for "apic-id" property...
Checking PATCH 34/45: pc: use get_uint() for "hpet-intcap" property...
Checking PATCH 35/45: xen: use get_uint() for "max-ram-below-4g" property...
Checking PATCH 36/45: arm: use get_uint() for "mp-affinity" property...
Checking PATCH 37/45: auxbus: use get_uint() for "addr" property...
Checking PATCH 38/45: pvpanic: use get_uint() for "ioport" property...
Checking PATCH 39/45: pnv-core: use get_uint() for "core-pir" property...
Checking PATCH 40/45: numa: use get_uint() for "size" property...
Checking PATCH 41/45: i386/cpu: use get_uint() for "min-level"/"min-xlevel" 
properties...
Checking PATCH 42/45: console: use get_uint() for "head" property...
Checking PATCH 43/45: tests/qdict: check more get_try_int() cases...
Checking PATCH 44/45: RFC: qdict: add uint...
Checking PATCH 45/45: qobject: move dump_qobject() from block/ to qobject/...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden