[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 0/2] s390x cpu model improvements for KVM
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH v1 0/2] s390x cpu model improvements for KVM |
Date: |
Thu, 1 Jun 2017 12:10:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/31/2017 09:34 PM, David Hildenbrand wrote:
> We should properly forward the CPUID format bit. CPU model
> detection on systems without IBC might select a model with a wrong
> CPU type (esp. selecting the business class (BC) model on an enterprise
> class (EC) machine). So let's improve that, too.
>
> I am also preparing a patch to properly indicate the correct cpu type
> to the guest via STORE CPU ID and STORE HYPERVISOR INFORMATION for the
> TCG case, but will send that separately after I tested it (want to write a
> kvm-unit-test for STORE CPU ID).
>
> David Hildenbrand (2):
> s390x/cpumodel: take care of the cpuid format bit for KVM
> s390x/cpumodel: improve defintion search without an IBC
>
> target/s390x/cpu_models.c | 10 ++++++++++
> target/s390x/cpu_models.h | 10 +++++++---
> target/s390x/kvm.c | 1 +
> 3 files changed, 18 insertions(+), 3 deletions(-)
>
I like both patches in terms of "yes, its the right thing to do".
Jason can you have a look? I might need some days to catch up
with other things before I can look into the patches.
- Re: [Qemu-devel] [PATCH v1 0/2] s390x cpu model improvements for KVM,
Christian Borntraeger <=