Re: [Qemu-devel] [PATCH v2 06/45] object: fix potential leak in getters

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> If the property is not of the requested type, the getters will leak a
> QObject.
>
> Signed-off-by: Marc-André Lureau <address@hidden>

Missing
Reviewed-by: Eric Blake <address@hidden>

> ---
>  qom/object.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index eb4bc924ff..c7b8079df6 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -1122,7 +1122,7 @@ char *object_property_get_str(Object *obj, const char 
> *name,
>          retval = g_strdup(qstring_get_str(qstring));
>      }
>  
> -    QDECREF(qstring);
> +    qobject_decref(ret);
>      return retval;
>  }
>  
> @@ -1183,7 +1183,7 @@ bool object_property_get_bool(Object *obj, const char 
> *name,
>          retval = qbool_get_bool(qbool);
>      }
>  
> -    QDECREF(qbool);
> +    qobject_decref(ret);
>      return retval;
>  }
>  
> @@ -1214,7 +1214,7 @@ int64_t object_property_get_int(Object *obj, const char 
> *name,
>          retval = qint_get_int(qint);
>      }
>  
> -    QDECREF(qint);
> +    qobject_decref(ret);
>      return retval;
>  }

Reviewed-by: Markus Armbruster <address@hidden>