Re: [Qemu-devel] [PATCH v2 0/7] migration: s390x css migration

[Cornelia Huck]

On Mon, 29 May 2017 15:55:13 +0200
Halil Pasic <address@hidden> wrote:

> The scope of this patch series is now limited to decoupling channel
> subsystem migration from the migration of virtio-ccw proxies.
> 
> The vmstatifying of virtio-ccw proxies is now done by another series
> currently consisting of a single  patch running under the name 'vmstatify
> config migration for virtio-ccw'. Since this series depends on that
> patch, I have included it here too (for convenience).
> 
> The reorganization was requested by Dave.
> 
> v1 --> v2:
> * Split out the vmystatify virtio-ccw part, reorganize
> * Use WITH_TMP instead of one-shot VMStateInfo's 
> 
> Halil Pasic (7):
>   s390x: vmstatify config migration for virtio-ccw
>   s390x: add helper get_machine_class
>   s390x: add css_migration_enabled to machine class
>   s390x/css: add missing css state conditionally
>   s390x/css: add ORB to SubchDev
>   s390x/css: activate ChannelSubSys migration
>   s390x/css: use SubchDev.orb
> 
>  hw/intc/s390_flic.c                |  48 ++++
>  hw/s390x/ccw-device.c              |  10 +
>  hw/s390x/ccw-device.h              |   4 +
>  hw/s390x/css.c                     | 494 
> +++++++++++++++++++++++++------------
>  hw/s390x/s390-virtio-ccw.c         |  58 +++--
>  hw/s390x/virtio-ccw.c              | 155 ++++++------
>  include/hw/s390x/css.h             |  17 +-
>  include/hw/s390x/s390-virtio-ccw.h |   7 +
>  include/hw/s390x/s390_flic.h       |   5 +
>  9 files changed, 544 insertions(+), 254 deletions(-)
> 

This patch set looks good to me, just some comments on the individual
patches.