Re: [Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

[Ben Warren]

> On Jun 1, 2017, at 7:52 AM, Michael S. Tsirkin <address@hidden> wrote:
> 
> On Thu, Jun 01, 2017 at 07:46:24AM -0700, Ben Warren wrote:
>> 
>>> On Jun 1, 2017, at 7:21 AM, Michael S. Tsirkin <address@hidden> wrote:
>>> 
>>> On Thu, Jun 01, 2017 at 08:10:27AM +0000, Marc-André Lureau wrote:
>>>> Hi
>>>> 
>>>> On Mon, May 29, 2017 at 7:18 PM Ben Warren via Qemu-devel <
>>>> address@hidden> wrote:
>>>> 
>>>>   From: Ben Warren <address@hidden>
>>>> 
>>>>   The following tests are implemented:
>>>>   * test that a GUID passed in by command line is propagated to the guest.
>>>>     Read the GUID from guest memory
>>>>   * test that the "auto" argument to the GUID generates a valid GUID, as
>>>>     seen by the guest.
>>>>   * test that a GUID passed in can be queried from the monitor
>>>> 
>>>>     This patch is loosely based on a previous patch from:
>>>>     Gal Hammer <address@hidden>  and Igor Mammedov <address@hidden>
>>>> 
>>>>   Signed-off-by: Ben Warren <address@hidden>
>>>>   Reviewed-by: Igor Mammedov <address@hidden>
>>>>   ---
>>> 
>>> What happened to indentation here?
>>> 
>> I don’t know, this is unchanged from the patch that passed through the 
>> gauntlet earlier this year, other than rebasing.  If you can please clarify 
>> exactly what you see that is wrong, that’ll be helpful.
> 
> That question is directed to Marc-André - when he replied to your patch
> he has corrupted the indentation.

OK :)  Thanks
> 
>>>>   +             * in order to implement the "OVMF SDT Header probe
>>>>   suppressor"
>>>>   +             * see docs/specs/vmgenid.txt for more details
>>>>   +             */
>>>>   +            return vgid_table.vgia_val + VMGENID_GUID_OFFSET;
>>>>   +        }
>>>> 
>>>> 
>>>> It leaks tables
>>>> 
>>>> Other than that:
>>>> Reviewed-by: Marc-André Lureau <address@hidden>
>>> 
>>> Ben, are you going to post a version that doesn't leak?
>> Yes, I’ll try to get to it today.
>> 
>> —Ben