[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling |
Date: |
Thu, 1 Jun 2017 20:55:19 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6ccf47f ppc: Rework CPU compatibility testing across migration
2b75df3 pseries: Reset CPU compatibility mode
282a89c pseries: Move CPU compatibility property to machine
8741a73 qapi: add explicit null to string input and output visitors
=== OUTPUT BEGIN ===
Checking PATCH 1/4: qapi: add explicit null to string input and output
visitors...
Checking PATCH 2/4: pseries: Move CPU compatibility property to machine...
Checking PATCH 3/4: pseries: Reset CPU compatibility mode...
Checking PATCH 4/4: ppc: Rework CPU compatibility testing across migration...
ERROR: braces {} are necessary for all arms of this statement
#94: FILE: target/ppc/machine.c:236:
+ if (cpu->compat_pvr) {
[...]
+ } else
[...]
total: 1 errors, 0 warnings, 100 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling, David Gibson, 2017/06/01
- [Qemu-devel] [PATCHv5 1/4] qapi: add explicit null to string input and output visitors, David Gibson, 2017/06/01
- [Qemu-devel] [PATCHv5 4/4] ppc: Rework CPU compatibility testing across migration, David Gibson, 2017/06/01
- [Qemu-devel] [PATCHv5 3/4] pseries: Reset CPU compatibility mode, David Gibson, 2017/06/01
- [Qemu-devel] [PATCHv5 2/4] pseries: Move CPU compatibility property to machine, David Gibson, 2017/06/01
- Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling,
no-reply <=
- Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling, David Gibson, 2017/06/08
- Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling, Andrea Bolognani, 2017/06/10
- Re: [Qemu-devel] [Qemu-ppc] [PATCHv5 0/4] Clean up compatibility mode handling, Andrea Bolognani, 2017/06/13