[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 18/45] qdev: make default property int
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 18/45] qdev: make default property int |
|
Date: |
Fri, 02 Jun 2017 15:49:40 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> The following patch will add uint properties.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
"Make default property int" doesn't make sense to me. The patch does
two things:
1. Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_INT(), to prepare for the
next patch's DEFINE_PROP_UINT().
2. Wrap the Property default value (an int64_t) in a union, to prepare
for the next patch adding a uint64_t.
If you split the patch accordingly, the commit messages will write
themselves :)
I'd use DEFINE_PROP_SIGNED() to avoid misleading readers into making a
connection to type int, and DEFINE_PROP_UNSIGNED() to match.
Other than that, the patch looks good.
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 18/45] qdev: make default property int,
Markus Armbruster <=