Re: [Qemu-devel] [PULL v2 00/34] Misc patches for 2016-06-01

[Peter Maydell]

On 2 June 2017 at 09:06, Paolo Bonzini <address@hidden> wrote:
> On 01/06/2017 19:56, Peter Maydell wrote:
>> On 1 June 2017 at 18:53, Peter Maydell <address@hidden> wrote:
>>> Test failure on OSX:
>>>
>>> TEST: tests/device-introspect-test... (pid=66373)
>>>   /aarch64/device/introspect/list:                                     OK
>>>   /aarch64/device/introspect/none:                                     OK
>>>   /aarch64/device/introspect/abstract:                                 OK
>>>   /aarch64/device/introspect/concrete:                                 **
>>> ERROR:/root/qemu/qom/object.c:364:object_initialize_with_type:
>>> assertion failed: (type != NULL)
>>> Broken pipe
>>
>> Got those the wrong way round -- this is the FreeBSD failure
>> and the other lot are OSX. Pretty sure it's the same error,
>> though -- it's just that for some reason my OSX setup doesn't
>> actually cause make to exit with an error when a test fails,
>> so it goes on to hit what's probably the same bug in all the
>> other check-qtest-$ARCH targets rather than bailing out.
>
> Thanks, any chance you can bisect these?  I'll install a FreeBSD VM next
> week.

No bisection, but using QTEST_LOG:

QTEST_LOG=1 QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64
QTEST_QEMU_IMG=qemu-img MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM %
255 + 1))} gtester -k --verbose -m=quick tests/device-introspect-test
-p=/aarch64/device/introspect/concrete
[...]
{"return": "/machine (none-machine)\r\n  /peripheral (container)\r\n
/peripheral-anon (container)\r\n  /unattached (container)\r\n
/io[0] (qemu:memory-region)\r\n    /sysbus (System)\r\n    /system[0]
(qemu:memory-region)\r\n"}{"execute": "device-list-properties",
"arguments": {"typename": "vhost-user-scsi-pci"}}

**
ERROR:/Users/pm215/src/qemu-for-merges/qom/object.c:364:void
object_initialize_with_type(void *, size_t, TypeImpl *): assertion
failed: (type != NULL)
Broken pipe
FAIL

suggests that there's a bug in the new vhost-user-scsi-pci
device. Specifically in commit 550811c37e0f2
("vhost-user-scsi: Introduce vhost-user-scsi host device")
hw/virtio/virtio-pci.c is changed to unconditionally call
type_register_static(&vhost_user_scsi_pci_info), whose
instance_init method tries to use TYPE_VHOST_USER_SCSI,
but hw/scsi/vhost-user-scsi.c (where that type is defined)
is only compiled if CONFIG_VHOST_USER_SCSI is set (which
only happens for Linux).

thanks
-- PMM