[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 21/69] target/s390x: Use unwind data for helper_tr
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 21/69] target/s390x: Use unwind data for helper_tr |
Date: |
Sun, 4 Jun 2017 10:34:21 -0700 |
Reviewed-by: Aurelien Jarno <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/s390x/mem_helper.c | 25 +++++++++++++++----------
target/s390x/translate.c | 1 -
2 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 0701e10..b37a963 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -723,19 +723,24 @@ void HELPER(unpk)(CPUS390XState *env, uint32_t len,
uint64_t dest,
}
}
-void HELPER(tr)(CPUS390XState *env, uint32_t len, uint64_t array,
- uint64_t trans)
+static void do_helper_tr(CPUS390XState *env, uint32_t len, uint64_t array,
+ uint64_t trans, uintptr_t ra)
{
- int i;
+ uint32_t i;
for (i = 0; i <= len; i++) {
- uint8_t byte = cpu_ldub_data(env, array + i);
- uint8_t new_byte = cpu_ldub_data(env, trans + byte);
-
- cpu_stb_data(env, array + i, new_byte);
+ uint8_t byte = cpu_ldub_data_ra(env, array + i, ra);
+ uint8_t new_byte = cpu_ldub_data_ra(env, trans + byte, ra);
+ cpu_stb_data_ra(env, array + i, new_byte, ra);
}
}
+void HELPER(tr)(CPUS390XState *env, uint32_t len, uint64_t array,
+ uint64_t trans)
+{
+ return do_helper_tr(env, len, array, trans, GETPC());
+}
+
uint64_t HELPER(tre)(CPUS390XState *env, uint64_t array,
uint64_t len, uint64_t trans)
{
@@ -1265,9 +1270,9 @@ uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc,
uint64_t v1,
get_address(env, 0, b2, d2), 0);
break;
case 0xc00:
- helper_tr(env, l, get_address(env, 0, b1, d1),
- get_address(env, 0, b2, d2));
- break;
+ do_helper_tr(env, l, get_address(env, 0, b1, d1),
+ get_address(env, 0, b2, d2), 0);
+ return cc;
case 0xd00:
cc = helper_trt(env, l, get_address(env, 0, b1, d1),
get_address(env, 0, b2, d2));
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 4978f19..1842cc3 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -4065,7 +4065,6 @@ static ExitStatus op_tprot(DisasContext *s, DisasOps *o)
static ExitStatus op_tr(DisasContext *s, DisasOps *o)
{
TCGv_i32 l = tcg_const_i32(get_field(s->fields, l1));
- potential_page_fault(s);
gen_helper_tr(cpu_env, l, o->addr1, o->in2);
tcg_temp_free_i32(l);
set_cc_static(s);
--
2.9.4
- [Qemu-devel] [PULL 12/69] target/s390x: Use unwind data for helper_mvpg, (continued)
- [Qemu-devel] [PULL 12/69] target/s390x: Use unwind data for helper_mvpg, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 09/69] target/s390x: Use unwind data for helper_clm, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 13/69] target/s390x: Use unwind data for helper_mvst, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 15/69] target/s390x: Use unwind data for helper_stam, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 16/69] target/s390x: Use unwind data for helper_mvcl, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 14/69] target/s390x: Use unwind data for helper_lam, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 18/69] target/s390x: Use unwind data for helper_clcle, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 20/69] target/s390x: Use unwind data for helper_unpk, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 17/69] target/s390x: Use unwind data for helper_mvcle, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 19/69] target/s390x: Use unwind data for helper_cksm, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 21/69] target/s390x: Use unwind data for helper_tr,
Richard Henderson <=
- [Qemu-devel] [PULL 23/69] target/s390x: Use unwind data for helper_trt, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 25/69] target/s390x: Use unwind data for helper_lctl, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 22/69] target/s390x: Use unwind data for helper_tre, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 24/69] target/s390x: Use unwind data for helper_lctlg, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 26/69] target/s390x: Use unwind data for helper_stctl, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 28/69] target/s390x: Use unwind data for helper_tprot, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 27/69] target/s390x: Use unwind data for helper_testblock, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 29/69] target/s390x: Use unwind data for helper_lra, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 32/69] target/s390x: Fix EXECUTE with R1==0, Richard Henderson, 2017/06/04
- [Qemu-devel] [PULL 31/69] target/s390x: Fix some helper_ex problems, Richard Henderson, 2017/06/04