[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/8] tpm-backend: Remove unneeded member vari
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 1/8] tpm-backend: Remove unneeded member variable from backend class |
|
Date: |
Mon, 05 Jun 2017 09:57:34 +0000 |
Hi
On Mon, Jun 5, 2017 at 11:22 AM Valluri, Amarnath <
address@hidden> wrote:
> On Wed, 2017-05-24 at 14:34 +0000, Marc-André Lureau wrote:
>
> Hi
>
> On Tue, May 16, 2017 at 12:00 PM Amarnath Valluri <
> address@hidden> wrote:
>
> TPMDriverOps inside TPMBackend is not required, as it is supposed to be a
> class
> member. The only possible reason for keeping in TPMBackend was, to get the
> backend type in tpm.c where dedicated backend api, tpm_backend_get_type()
> is
> present.
>
> Signed-off-by: Amarnath Valluri <address@hidden>
>
>
> Please add & keep my r-b tags from previous iterations in commit message
> if they are no or only minor changes.
>
> Marc, do you mean to resend the patch set by keeping 'Reviewed-by:' tag
> for commits.
>
On the patches I gave a "Reviewed-by", you should add it to the commit
message. Next resend of the series should have them.
--
Marc-André Lureau