Re: [Qemu-devel] [PULL 00/15] chardev patches

[Peter Maydell]

On 5 June 2017 at 11:50, Marc-André Lureau <address@hidden> wrote:
> Hi
>
> On Mon, Jun 5, 2017 at 2:15 PM Peter Maydell <address@hidden>
> wrote:
>>
>> On 2 June 2017 at 20:15, Marc-André Lureau <address@hidden>
>> wrote:
>> > Sorry, git-publish printed an error on invalid remote, but keep going. I
>> > should fix it. Here is the new pull request:
>> >
>> > The following changes since commit
>> > 43771d5d92312504305c19abe29ec5bfabd55f01:
>> >
>> >   Merge remote-tracking branch
>> > 'remotes/armbru/tags/pull-qapi-2017-05-31'
>> > into staging (2017-06-01 16:39:16 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >   https://github.com/elmarco/qemu.git tags/chrfe-pull-request
>> >
>> >
>> > for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:
>> >
>> >   char: move char devices to chardev/ (2017-06-02 11:33:53 +0400)
>>
>> Thanks, applied to master.
>>
>> You forgot to add your signed-off-by line as submaintainer to the
>> commit from Philippe -- since it's a two line patch I didn't think it
>
>
> Oh I didn't know I have to add my sign-off too, I thought reviewed-by was
> enough. Ok

Yeah, the reviewed-by: says "this code looks good", but the signed-off-by:
says "this code passed through me on its way to master". So you can have
any combination:
 * reviewed-by: only -- you just reviewed the code and it went into
   master via somebody else's tree
 * signed-off-by: only -- you took the code through your tree (so you're
   happy that it's ok license-wise and so on), but you're relying on
   somebody else to have reviewed it
 * both -- you took the code through your tree, and you've done the
   code review

thanks
-- PMM