[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] s390x: vmstatify config migration for vi
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] s390x: vmstatify config migration for virtio-ccw |
|
Date: |
Mon, 5 Jun 2017 07:19:14 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/04/2017 10:09 PM, Dong Jia Shi wrote:
> * Halil Pasic <address@hidden> [2017-06-02 16:05:31 +0200]:
>
> Hi Halil,
>
> Sorry for the late show up. I just found some nits, which could be
> ignored for me.
>
>> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
>> flexibility (extending using subsections) and for fun.
>>
>> To achieve this we need to hack the config_vector, which is VirtIODevice
>> (that is common virtio) state, in the middle of the VirtioCcwDevice state
>> representation. This is somewhat ugly, but we have no choice because the
> ^^
> Nit:-------------++
What's wrong here? Two spaces between sentences is a common
typographical convention (true, the codebase is inconsistent on whether
sentences are separated with one or two spaces, but that's all the more
reason to realize that since we don't have a consistent standard, it is
just churn to change from one style to the other)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature