Re: [Qemu-devel] [PULL 17/33] vhost-user-scsi: Introduce vhost-user-scsi host device

[Felipe Franciosi]

> On 5 Jun 2017, at 17:28, Eric Blake <address@hidden> wrote:
> 
> On 06/01/2017 07:41 AM, Paolo Bonzini wrote:
>> From: Felipe Franciosi <address@hidden>
>> 
>> This commit introduces a vhost-user device for SCSI. This is based
>> on the existing vhost-scsi implementation, but done over vhost-user
>> instead. It also uses a chardev to connect to the backend. Unlike
>> vhost-scsi (today), VMs using vhost-user-scsi can be live migrated.
>> 
>> To use it, start Qemu with a command line equivalent to:
>> 
>> qemu-system-x86_64 \
>>       -chardev socket,id=vus0,path=/tmp/vus.sock \
>>       -device vhost-user-scsi-pci,chardev=vus0,bus=pci.0,addr=...
>> 
>> A separate commit presents a sample application linked with libiscsi to
>> provide a backend for vhost-user-scsi.
>> 
>> Signed-off-by: Felipe Franciosi <address@hidden>
>> Message-Id: <address@hidden>
>> ---
> 
> This pull request still hasn't landed, and now it needs a rebase:

Hi Eric,

Thanks for the report. Looks simple. Part of the series have been merged. 
Should I rebase+resend just the two missing patches (as a new series?) or 
should Paolo do this? I'm not sure what's the workflow here.

Cheers,
Felipe

> 
>> +++ b/hw/scsi/vhost-user-scsi.c
> 
>> +#include "hw/virtio/virtio-access.h"
>> +#include "sysemu/char.h"
> 
> Now that commit 6b10e573 is on mainline, sysemu/char.h has been renamed
> to chardev/char.h (there may be other changes needed, too).
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org