Re: [Qemu-devel] [RISU PATCH v4 08/10] risu: add support compressed tracefiles

[Peter Maydell]

On 2 June 2017 at 17:08, Alex Bennée <address@hidden> wrote:
> This uses the magic of zlib's gzread/write interface to wrap the
> tracefile in compression. The code changes are tiny. I spent more time
> messing about with the configure/linker stuff to auto-detect bits.
>
> As you need decent multi-arch support or a correctly setup cross
> toolchain we fall back if we can't compile with zlib. This
> unfortunately needs some #ifdef hackery around the zlib bits in
> risu.c.
>
> Signed-off-by: Alex Bennée <address@hidden>
>
> --
> v4
>   - removed redundant config.h output, added HAVE_ZLIB
>   - added BUILD_INC to deal with out-of-tree builds

I thought the trace files were so enormous that zlib was
basically mandatory for the record/replay to be useful?
I'm wondering if we should use a submodule for zlib and
just build it locally. That would let us just make it a
hard requirement (and avoid the need to do things with
docker).

thanks
-- PMM